summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Kiagiadakis <george.kiagiadakis@collabora.co.uk>2011-04-08 17:01:44 (GMT)
committerGeorge Kiagiadakis <george.kiagiadakis@collabora.co.uk>2011-04-08 17:01:44 (GMT)
commit1f433cb0fa18d50ba4bf2b3ea3246b9dc02ef47d (patch)
treef6259f90b20121c7ea245eb7dd83bbc775f1390a
parent67029b5ca854fe791d32f9b7e0a0f5737ec866fb (diff)
downloadtelepathy-qt4-logger-fixes.tar.gz
telepathy-qt4-logger-fixes.tar.xz
Add some review commentsfixes
-rw-r--r--TelepathyQt4Logger/Models/logger-conversation-model.h3
-rw-r--r--TelepathyQt4Logger/logger.h4
-rw-r--r--TelepathyQt4Logger/types.h1
3 files changed, 8 insertions, 0 deletions
diff --git a/TelepathyQt4Logger/Models/logger-conversation-model.h b/TelepathyQt4Logger/Models/logger-conversation-model.h
index 7eb94c6..74a83c4 100644
--- a/TelepathyQt4Logger/Models/logger-conversation-model.h
+++ b/TelepathyQt4Logger/Models/logger-conversation-model.h
@@ -40,6 +40,9 @@ public:
LoggerConversationModel(const Tp::AccountPtr &account, const Tp::ContactPtr &contact, QObject *parent = 0);
virtual ~LoggerConversationModel();
+ //REVIEW: what exactly do these do? it is not clear from their names
+ //if they are used to check if more data can be fetched, as I guess,
+ //why not use the Qt models way (canFetchMore() and fetchMore()) ?
Q_INVOKABLE virtual bool canFetchMoreBack() const;
Q_INVOKABLE virtual void fetchMoreBack();
virtual bool backFetching() const;
diff --git a/TelepathyQt4Logger/logger.h b/TelepathyQt4Logger/logger.h
index cd8f593..03bb146 100644
--- a/TelepathyQt4Logger/logger.h
+++ b/TelepathyQt4Logger/logger.h
@@ -33,6 +33,8 @@
namespace Tpl
{
+
+//REVIEW: Do these defines need to be public?
#define TPL_DBUS_SRV_WELL_KNOWN_BUS_NAME \
"org.freedesktop.Telepathy.Logger"
#define TPL_DBUS_SRV_OBJECT_PATH \
@@ -45,6 +47,8 @@ class TELEPATHY_QT4_LOGGER_EXPORT Logger : public Tp::StatelessDBusProxy
Q_OBJECT
public:
+ //REVIEW: shouldn't this class have a create() method and be used
+ //with LoggerPtr just like everything else in tp-qt4?
Logger();
~Logger();
diff --git a/TelepathyQt4Logger/types.h b/TelepathyQt4Logger/types.h
index c8d14ec..05e5a47 100644
--- a/TelepathyQt4Logger/types.h
+++ b/TelepathyQt4Logger/types.h
@@ -71,6 +71,7 @@ typedef QList<EventPtr> EventPtrList;
typedef QList<QDate> QDateList;
typedef QList<SearchHit> SearchHitList;
+//REVIEW: the event argument should be: const EventPtr & event
typedef bool (*LogEventFilter)(EventPtr event, void *user_data);
} //namespace