summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoryunchao.he <yunchao.he@intel.com>2016-09-21 07:42:40 (GMT)
committerCommit bot <commit-bot@chromium.org>2016-09-21 07:44:48 (GMT)
commit6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab (patch)
treeb0f972d250bfe1b98422cb293d14af990e23a2ed
parent62ade417517f7fd5486deb52794edde6427ccfbe (diff)
downloadchromium-6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab.tar.gz
chromium-6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab.tar.xz
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb image to single-sampled srgb image.
Per our discussion with @piman and @kbr at https://codereview.chromium.org/2286593002/, The current code is correct, no further work to be done. Simply remove this TODO is OK. BUG=634525 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2356813002 Cr-Commit-Position: refs/heads/master@{#420001}
-rw-r--r--gpu/command_buffer/service/gles2_cmd_decoder.cc2
1 files changed, 0 insertions, 2 deletions
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index aad72d6..80bd8d9 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -7709,8 +7709,6 @@ void GLES2DecoderImpl::DoBlitFramebufferCHROMIUM(
bool encode_srgb_only =
(draw_buffers_has_srgb && !read_buffer_has_srgb) &&
((mask & GL_COLOR_BUFFER_BIT) != 0);
- // TODO(yunchao) Need to revisit here if the read buffer is a multi-sampled
- // renderbuffer.
if (!enable_srgb ||
read_buffer_samples > 0 ||
!feature_info_->feature_flags().desktop_srgb_support ||